absolute-version / commit-and-tag-version

Fork of the excellent standard-version. Automate versioning and CHANGELOG generation, with semver.org and conventionalcommits.org :trophy:
ISC License
421 stars 40 forks source link

fix: print version number that updater.writeVersion returns #11

Closed TimothyJones closed 2 years ago

TimothyJones commented 2 years ago

Copy of https://github.com/conventional-changelog/standard-version/pull/670

BEGIN_COMMIT_OVERRIDE fix: When a custom updater reports a version other than the new computed semver, that version is now correctly reported in log output END_COMMIT_OVERRIDE


For custom updaters that derive the new version from the file contents (e.g. newVersion = oldVersion + 1), the log output was showing the new computed semver version, rather than the actual version applied by the updater. This PR corrects the output for such custom updaters.

Closes expo-community/standard-version-expo#18. Closes expo-community/standard-version-expo#10.

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f6a7430). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #11   +/-   ##
=========================================
  Coverage          ?   97.62%           
=========================================
  Files             ?       26           
  Lines             ?     1177           
  Branches          ?        0           
=========================================
  Hits              ?     1149           
  Misses            ?       28           
  Partials          ?        0           

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more