Closed mbwhite closed 6 months ago
npm run format:fix
will fix the build error
This is great, thanks so much for the PR! AND documentation and tests! 🙌🎉
I left a couple questions inline - Also, do you think the argument would be better named
—signoff
, to match the git argument that people might be looking for?
thanks :-)
I'd debated with myself on that exact question. Using --signoff
to match git as you say is valid... but I settled on --signedoff
as I was worried that it was very close to the tools --sign
option.
Would commit-and-tag-version --sign --signoff
be confusing?
Happy to go within either spelling :-)
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
cd0f921
) 94.42% compared to head (42b05bc
) 94.43%. Report is 1 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I see what you are saying about the ambiguity, but I reckon that’s a risk either way.
Even if the alternative is more ambiguous, I reckon that the consistency with git is worth it.
Thanks @TimothyJones
Thank you for the contribution! Releasing 12.1.0 now, should be live shortly.
Our current process required that the
git commit --signoff
is used to add asigned-off-by
trailer to the commit message.Adding an additional CLI option to permit this to be added.