search

absolute-version / commit-and-tag-version

Fork of the excellent standard-version. Automate versioning and CHANGELOG generation, with semver.org and conventionalcommits.org :trophy:
ISC License
360 stars 33 forks source link

feat(updater): add maven pom.xml file support (#33, #109) #123

Closed TaylorHo closed 6 months ago

TaylorHo commented 6 months ago

Hi! As I commented here, on the PR #109, these are the changes that add support for Maven projects, using the pom.xml version file.

All the work has been done by @paul-barton, but since the PR #109 hasn't had any updates in a while, I have forked it, fixed the tests, and fixed the updater configuration, and it's now working fine!

This PR is part of the updaters for non-node projects, as explained on Issue #33.

TaylorHo commented 6 months ago

@TimothyJones Can you review, please?

codecov-commenter commented 6 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c137339) 94.43% compared to head (be6c08c) 94.11%.

Files Patch % Lines
lib/updaters/index.js 0.00% 2 Missing :warning:
lib/updaters/types/maven.js 95.83% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #123 +/- ## ========================================== - Coverage 94.43% 94.11% -0.32% ========================================== Files 25 26 +1 Lines 467 493 +26 ========================================== + Hits 441 464 +23 - Misses 26 29 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.