refactor: migration to ESM

absolute-version / commit-and-tag-version

Fork of the excellent standard-version. Automate versioning and CHANGELOG generation, with semver.org and conventionalcommits.org :trophy:

ISC License

425 stars 40 forks source link

refactor: migration to ESM #201

Open gian1200 opened 4 weeks ago

gian1200 commented 4 weeks ago

DO NOT MERGE: Tests pending

Summary

Quick migration to ESM
Added some workarounds to path handling (in defaults.mjs)
Modified Script to explicitly use node (npm run release doesn't work)
Reorder imports in the following order:
- Node native packages
- Dependency packages
- Project modules

gian1200 commented 3 weeks ago

Migration to ESM is almost complete. However I'm facing an issue.

Looks like Jest does not have an stable version compatible with ESM. It currently only provides an experimental support. However not all commit-and-tag-version tests run correctly in this mode.

I've read that some suggest to migrate to Vitest while others to Mocha. I've not used Vitest, but I do have some experience with Mocha. Migration looks doable on any of them.

@TimothyJones do you have any opinion or suggestion regarding this?

TimothyJones commented 3 weeks ago

I feel like the community is moving towards vitest, and it's supposed to be jest compatible these days - shall we try that?

TimothyJones commented 3 weeks ago

And, thanks again for all your hard work on this - so so much appreciated!!

gian1200 commented 3 weeks ago

No problem. To be fair, I'm partially motivated by the fix that is available in the last version 😅.

Regarding Vitest, it's something I've never used, but will try to implement it (in a separate PR).