search

absolute-version / commit-and-tag-version

Fork of the excellent standard-version. Automate versioning and CHANGELOG generation, with semver.org and conventionalcommits.org :trophy:
ISC License
423 stars 40 forks source link

Confusion around version bumps #205

Closed Maelstromeous closed 3 hours ago

Maelstromeous commented 5 hours ago

Hello,

I have tested this package and commited with a message of feat(repo): This should be a minor version but upon running the command commit-and-tag-version it bumped it as a patch (0.0.1) instead of a minor (0.1.0).

Here is my package.json script:

  "scripts": {
    "release": "commit-and-tag-version",
    "release-dry": "commit-and-tag-version --dry-run"
  },

I run the command via pnpm run release. I confirmed it also happens with npm as well.

I have no additional files that could be influencing the behaviour of the package.

TimothyJones commented 3 hours ago

See the note at the end of the readme here: https://github.com/absolute-version/commit-and-tag-version?tab=readme-ov-file#why-do-breaking-changes-before-100-not-trigger-a-100-release

Before version 1.0.0, semver has no opinion on what the numbers mean.

This tool follows the common convention of minor being a breaking change, and patch being for everything else (until you release 1.0.0, then it will follow semver).

Maelstromeous commented 3 hours ago

Thank you for the insights, I totally missed that part of the readme! In terms of this package's issue, I'll close this off :)

TimothyJones commented 3 hours ago

No worries! It’s a long readme, I should restructure it at some point