search

absolute-version / commit-and-tag-version

Fork of the excellent standard-version. Automate versioning and CHANGELOG generation, with semver.org and conventionalcommits.org :trophy:
ISC License
385 stars 36 forks source link

chore: Full conversion to typescript (#29) #74

Open SharpSeeEr opened 1 year ago

SharpSeeEr commented 1 year ago

There are some TODO: comments scattered around in places where I honestly had no idea what to do.

TimothyJones commented 1 year ago

Looks like the build failure is real, too: https://github.com/absolute-version/commit-and-tag-version/actions/runs/4672719409/jobs/8275798247?pr=74#step:9:174

Error: lib/lifecycles/bump.ts(6,26): error TS7016: Could not find a declaration file for module 'dotgitignore'. '/home/runner/work/commit-and-tag-version/commit-and-tag-version/node_modules/dotgitignore/index.js' implicitly has an 'any' type.
TimothyJones commented 1 year ago

Sorry I didn't get to your other PR in time - I wanted to comment and say that incremental PRs with settings updates would be a good approach - we could potentially have done the tests + lint first without touching the implementation, then merged that in to the typescript branch. That comment seems obsolete now, though 😂

SharpSeeEr commented 1 year ago

I 100% agree that incremental PR's are the way to go. In my rush I opened this against master rather than the typescript conversion branch, which would allow more incremental PR's. I also screwed up by not renaming each file and then committing the change before making modifications so it shows as a rename instead of a delete and add.

As far as the build goes I didn't even try. I knew it wouldn't build at this stage. I'll work on converting the tests next.

TimothyJones commented 1 year ago

I'm afraid I'm not really sure what to do with this one - I don't think we can really call it a full conversion unless it builds.

What state is it currently in? I might convert it to a draft while the build doesn't run.