absolvent / gore-gulp

Simple way to run and maintain React.js projects without any configuration.
MIT License
1 stars 0 forks source link

webpack.production takes development instead of production react #54

Closed zangrafx closed 8 years ago

zangrafx commented 8 years ago

Problem: Despite setting environment variable to production gore-gulp takes dev react build instead of prod react build.

What I did:

SET NODE_ENV=production gulp webpack

What I got:

finished "webpack.production" - OK there are react debug warnings in console - NOT OK

zangrafx commented 8 years ago

I've found easy solution in this article http://dev.topheman.com/make-your-react-production-minified-version-with-webpack/ hence my pull request