search

abstiles / deluminate

An extension for Google Chrome (and Chromium) that inverts the luminance of websites.
BSD 2-Clause "Simplified" License
216 stars 43 forks source link

Enhance settings for scheme scoping. #36

Open wahidrahim opened 10 years ago

wahidrahim commented 10 years ago

I noticed this for http://heroku.com/. If I disable it at the main page, once I log in it is back to being inverted. Furthermore if I disable it then, the next link I click is deluminated and I end of disabling it for every page.

I think it would be great if users had a settings option where you can add "excluded sites" and could use wildcards: e.g. "Exclude: *.heroku.com, https://www.youtube.com/watch?"

abstiles commented 10 years ago

Looks like heroku.com takes you to www.heroku.com, and upon logging in you're redirected to dashboard.heroku.com. Clicking "databases" takes you to postgres.heroku.com, Add-ons takes you to addons.heroku.com, and so on, with each major section of a page given its own subdomain. How obnoxious!

Okay, so Deluminate treats every subdomain independently because there are a lot of times subdomains behave differently enough to warrant different inversion rules. Clearly the heroku site is rather pathological from this standpoint, though. You can just deal with it for now by manually choosing "Normal" for the page every time you hit a new subdomain, and it will remember it in the future (so the next time you land on, e.g., dashboard.heroku.com, it will be fine).

Down the road, I'm interested in adding more granular preferences for sites. I'd like the user to be able to easily set a scheme for all subdomains of a domain, and even for parts of a web page's path. I'm actually surprised I don't already have an issue here for that enhancement.

wahidrahim commented 10 years ago

Ah then the heroku website is a slightly different case, I understand now. I will bare with disabling for whatever page for now. The enhanced settings will be a great and powerful addition to this extension!