search

abstract-machine-learning / silva

Silvarum Interpretatione Lator Valens Analysis - Stability analyzer for tree ensemble calssifiers.
GNU General Public License v3.0
8 stars 2 forks source link

Forest custom voting function #3

Closed xai-365 closed 3 hours ago

xai-365 commented 4 hours ago

Hi,

I wanted to know if SILVA would work with a custom voting function other than max, average, or softargmax?

Best, Masood.

marco-zanella commented 4 hours ago

Hi Masood, at the current state only max, average and softargmax are implemented, but more can be added into forest.c (for the concrete domain) and abstract_interpreter/forest_hyperrectangle.c (for the abstract domain).

xai-365 commented 4 hours ago

Will adding for example, a custom 90% voting function (where all trees have to vote 90% for one class) affect the soundness or completeness of SILVA?

marco-zanella commented 4 hours ago

Each time a voting function is added, its abstract counterpart must be added (and manually defined) as well, thus soundness and completeness depends on the characteristics of the implementation of the abstract function. For a "90% voting" I see no problem, as it is quite similar to a max voting.

xai-365 commented 3 hours ago

So I need to make new functions similar to decorator_score_concrete_softargmax() and decision_function_softargmax() right?

marco-zanella commented 3 hours ago

Yes, that's correct

xai-365 commented 3 hours ago

Thank you so much!