search

abstracta / jmeter-java-dsl

Simple JMeter performance tests API
https://abstracta.github.io/jmeter-java-dsl/
Apache License 2.0
477 stars 59 forks source link

Feature request! Open Model Therad Group #122

Open kirillyu opened 2 years ago

kirillyu commented 2 years ago

It is awesome cool. And real open model! https://jmeter.apache.org/usermanual/component_reference.html#Open_Model_Thread_Group

rabelenda commented 2 years ago

Super fresh request considering that JMeter 5.5 was released today! Thank you for proposing it!

Do you see any particular value on it compared to the current solution the DSL provides aside from the dependency to a plugin that it now provides? I see it as replacement the existing usage of throughput shaping timer + concurrency thread group. I think we may incorporate it into existing rpsThreadGroup without any alterations to end user API and just replacing the underlying implementation. Any thoughts?

Regards

kirillyu commented 2 years ago

I was really looking forward to this feature!

I've looked at the new implementation a lot. I even ran some tests. This implementation is slightly more demanding on resources. But at the moment I can't say with certainty that it replaces the current implementation of RpsThreadGroup. A safe option in my opinion is to expand the implementation and support two thread groups in one implementation. Maybe with the .useOpenModel() method. All the same, in their model, these thread groups are slightly different. But it seems that this difference does not prevent us from starting to add a new thread group. The key feature of the new thread group is the amazing accuracy and reproducibility of results.

rabelenda commented 2 years ago

I wonder if makes sense to keep both thread group implementations. When would you use one and the other?

Do you have any link/article that compares the accuracy/reproducibility of results compared to existing Throughput Shaping Timer + Concurrency Thread Group? Would be nice to have it to include it in user guide, release notes or any place we want to give users information why did we do a change or when to use each alternative.

Thank you again for bringing this into attention.

kirillyu commented 2 years ago

I tested it locally. So the result has not been published. There is an overview https://qainsights.com/open-model-thread-group-in-jmeter/ , but the problem is that I don't know the deep characteristics of this thread group. How it works with connections, how it utilizes resources. I know its functionality and features, they are similar to RPS thread group, but the implementation is completely different. In my opinion, the implementation is important and you cannot replace one thread group with another only on the basis of functionality.