abstracta / jmeter-java-dsl

Simple JMeter performance tests API
https://abstracta.github.io/jmeter-java-dsl/
Apache License 2.0
467 stars 59 forks source link

Add support to jmeter-influxdb2-listener-plugin #236

Open 3amrSaad opened 10 months ago

3amrSaad commented 10 months ago

Add support to jmeter-influxdb2-listener-plugin (https://github.com/mderevyankoaqa/jmeter-influxdb2-listener-plugin) as it generates very useful metrics than the one already existing as it throws the requests raw data in the database so I think this would be a very useful feature to be added

rabelenda commented 10 months ago

Hello, thank you for bringing this into attention. I didn't know about this plugin, is very interesting.

What particular metrics you think are useful or are you using/or wish to use in your tests that the existing influxdb listener does not provide?

I reviewed very briefly the plugin, and it seems that adds latency, connection & processing time and response body (only for errors, and only for certain amount of errors). It also seems that imposes some limitations, eg: java 11+, jmeter 5.6.2, influxdb 2. Most of them look ok, but would require some special comment in user guide to avoid for example people having issues with java 8 or influxdb previous to 2.

Regards

3amrSaad commented 10 months ago

Hello,

Thank you for your prompt response and for considering the integration of this InfluxDB Plugin into JMeter DSL. I'm delighted to see your interest in this plugin, and I believe it would be a valuable addition.

Here are some specific metrics and use cases where I use this plugin:

So I was hoping to be able to use it through JMeter DSL as I am currently in the process of migrating from JMX Files to it and I have been heavily relying on this plugin and all of our Grafana Dashboards are built based on it, so your support in this would be highly appreciated.

Best Regards

3amrSaad commented 7 months ago

Hello, Any updates or timeline regarding this feature?

rabelenda commented 7 months ago

Hello, we don't have any timeline or updates regarding this feature. For the time being you can try using the wrapper element, you can build your own dsl element to support this listener, or you can propose some design or even a pr for the new feature.

I am a little hesitant to add something that requires java 11 and only have that feature requiring that right now. I have seen other listeners with similar features that we need to review farther to identify which is the best course of action in the long term. Finally, jmeter team is planning the release of jmeter 6, that I don't know how much it will take to be released, but is planned to drop java 8 support in favor of java 17, which would require JMeter DSL to move to that java version (if we want to stick with updated version of JMeter) and would avoid having one particular feature in the DSL requiring a particular java version.