abstracta / jmeter-java-dsl

Simple JMeter performance tests API
https://abstracta.github.io/jmeter-java-dsl/
Apache License 2.0
477 stars 59 forks source link

Refactored: Extracted class JmdslApplyDefaults from JmdslConfig #245

Closed Kabilesh020799 closed 1 year ago

Kabilesh020799 commented 1 year ago

I have extracted the class JmdslApplyDefaults from JmdslConfig, which had improved the code quality, and maintainability, and all made the class JmdslConfig focus on a single functionality. I kindly request you to merge this if you find this improves your code quality. Thanks

rabelenda commented 1 year ago

Thank you again for submitting another PR!

In this scenario, since logic is only used in that class, is tied to JmdslConfig logic and the class is so small, I would rather keep it where it is. Take into consideration that even though removing code from classes makes them easier to maintain, adding classes makes the general project more complex/harder to maintain (more classes=more structure=more dependencies), so there is a balance to keep an eye on between class complexity and project/dependencies complexity.