search

abstractfoundry / lumicube-daemon

10 stars 13 forks source link

Replace thirdparty JSON vendored code with Maven dependency #10

Closed mfoo closed 2 years ago

mfoo commented 2 years ago

This MR replaces the embedded copy of the JSON library green-jelly with a Maven dependency.

t looks like it's only recently been released to Maven Central (27th March 2022) so it's understandable why it needed to be included manually before.

Ideally this would go in after https://github.com/abstractfoundry/lumicube-daemon/pull/5. It's likely to conflict with https://github.com/abstractfoundry/lumicube-daemon/pull/8 due to the pom <configuration> change but I'll rebase as necessary.

abstractfoundry commented 2 years ago

Thanks @mfoo! I've merged into main, but I just removed the use of the greenJelly.version property.