search

abstractfoundry / lumicube-daemon

10 stars 13 forks source link

JUnit coverage #12

Open mfoo opened 2 years ago

mfoo commented 2 years ago

Hello!

I was wondering if you had a to-do list for areas of the codebase that could benefit from increased JUnit coverage? I can see that the coverage is currently quite low but also that a lot of the interactions with the OS (e.g. pacmd) might be difficult to test properly.

Either way, if you have a list of classes that handle important business logic, that'd be awesome, and it might be a good place for me (or somebody else) to start making changes - having a bigger safety net makes it simpler for new contributors to make changes and protects against errors from future refactoring.

abstractfoundry commented 2 years ago

Hi @mfoo - yes the test coverage is pretty low at the moment! As you say several bits are quite tricky to unit test. Off the top of my head, the areas of the codebase which could probably benefit most from adding unit tests are (although they probably need refactoring to allow for easier testing first):

and those for the following could certainly be expanded:

Sorry it's not a very helpful answer - if you have any thoughts on how to improve our testing, I would be very interested!