search

abstractfoundry / lumicube-daemon

9 stars 12 forks source link

Move log.xml to src/main/resources/logback.xml #16

Closed mfoo closed 1 year ago

mfoo commented 1 year ago

This MR moves the file log.xml to src/main/resources/logback.xml. This is because we have logback-classic as a backend for SLF4J, and logback will automatically look for this file on the classpath when it starts. This means we don't need to specify -Dlogback.configurationFile on each JVM execution. We can still provide that arg to use a different file though.

I have not tested any of the changes in nbactions.xml or build.sh - I don't know how, but they look sensible to me. Please let me know if there's something wrong.

Also please reject this if the file was deliberately named log.xml in the root!

abstractfoundry commented 1 year ago

Good stuff.

abstractfoundry commented 1 year ago

Thank you @mfoo!