abstractitptyltd / abstractit-puppet

Manage puppet agent, master, modules and hiera with puppet
https://forge.puppetlabs.com/abstractit/puppet
18 stars 44 forks source link

puppet::config ini_subsetting 'puppet sysconfig logdest' subsettings_delimeter #161

Open kokovikhinkv opened 7 years ago

kokovikhinkv commented 7 years ago

Resource puppet::config ini_subsetting 'puppet sysconfig logdest' generates ${sysconfigdir}/puppet with string without delimeter:

DAEMON_OPTS="--logdest/var/log/puppet/puppet.log"

Puppet agent can't parse option:

/usr/bin/ruby /usr/bin/puppet agent --no-daemonize --logdest/var/log/puppet/puppet.log
Error: Could not parse application options: invalid option: --logdest/var/log/puppet/puppet.log

Adding subsetting_key_val_separator can fix issue

  ini_subsetting { 'puppet sysconfig logdest':

    subsetting_key_val_separator => ' ',

  }
rendhalver commented 7 years ago

I would be happy to accept a PR. I don't have a lot of time to fix it right now but will get to it when I can.