Kalium 1.0.0?

[bendoerr]

I started off with the goal of adding all of the currently documented Libsodium interfaces to Kalium. I may have gotten a bit carried away cleaning up code though. Anyway this is my progress so far, no need to merge yet.

Goals

• Add all of the documented libsodium interfaces
• Provide OO style interfaces
• Review other OO style bindings to libsodium to see if we can make Kalium's bindings better
• Take a crack at #41
• Keep backwards compatibility to Kalium 0.4.0

[abstractj]

@bendoerr I'd say that would be better to split documentation and improvements in small PRs, when possible, it's better for visibility. Anyway is not a big deal, it will just take some time for a full review.

Regarding Kalium 1.0.0 or not. Let's leave it as is for now, more testing is required.

[bendoerr]

Sure, I'll split this up as much as I can.

I haven't had much time to work on it recently since I added the majority of the functionality that I needed. If I recall, I was blocked in one use case waiting for a bug fix to be merge into jnr-ffi/jffi... which looks like it has been merged and released now, so I'll include that in a future pull-request.

[abstractj]

@bendoerr thanks a million Ben

[abstractj]

@bendoerr here's my suggestion to get it merged. First, I really do appreciate your changes, but would like to do into this way.

1 I saw that you added several interfaces from libsodium and this is cool, at the same time I'd like to see the respective testing vectors for each interface (we can do it together in small steps). Otherwise Kalium would become just a Java library exposing plain C, the goal here is make it easy for people willing to consume crypto without having to care about what happens under the covers with libsodium.

Let's move to another PR the following commits please:

• Add SealedBox
• Update/Add crypto_secretbox APIs
• Update/Add crypto_auth APIs
• Add crypto_aead_chacha20poly1305
• Update/Add crypto_box APIs
• Update/Adds crypto_sign APIs
• Add/Update crypto_generichash APIs
• Add crypto_shorthash API
• Add AEAD AES256-GCM support
• Add back original pwhash_scryptsalsa208sha256 constants
• Add crypto_hash_sha[256,512] multi-part interfaces
• Add all of the cryptoauth* interfaces.
• Add crypto_onetimeauth interfaces.
• Add key agreement over X25519
• Add the cryptostream* interfaces
• Add ed25519 to curve25519 interfaces

2 Let's get only the interfaces that requires an update and put in a single PR. Because from what I noticed we don't have the testing vectors for the new methods.

• Update crypto_secretbox APIs
• Update crypto_auth APIs
• Update crypto_box APIs
• Update crypto_sign APIs
• Update crypto_generichash APIs

3 Let's add the remaining interfaces with testing vectors

• Add SealedBox
• Add crypto_aead_chacha20poly1305
• Add/Update crypto_generichash APIs
• Add crypto_shorthash API
• Add AEAD AES256-GCM support
• Add back original pwhash_scryptsalsa208sha256 constants
• Add crypto_hash_sha[256,512] multi-part interfaces
• Add all of the cryptoauth* interfaces.
• Add crypto_onetimeauth interfaces.
• Add key agreement over X25519
• Add the cryptostream* interfaces
• Add ed25519 to curve25519 interfaces

Sorry if it sounds frustrating, I could just cherry-pick your commits, but I really would like to preserve what you did. If all that I said make some sense to you, let's move forward.

[bendoerr]

@abstractj not frustrating at all. Your suggestion sounds like a good approach and I appreciate the guidance. I'll get new PR's up later today.

[bendoerr]

@abstractj How do you feel about 733d3e6? I think it would resolve #37 and keep things more clear for those of us that are familiar with libsodium. Edit. See PR #58.

[bendoerr]

@abstractj I've added the two noted PR's let's figure out where to go with those, then I'll start popping up the rest.

[abstractj]

I'm closing it, because I believe this PR is out of date.