abstractj / kalium

Java binding to the Networking and Cryptography (NaCl) library with the awesomeness of libsodium
http://abstractj.github.com/kalium/
Apache License 2.0
207 stars 74 forks source link

Made key pair class immutable #89

Closed hvas89 closed 6 years ago

abstractj commented 6 years ago

@hvas89 Thanks so much for spending time on this. We really appreciate it. However this issue was already adressed here: https://github.com/abstractj/kalium/commit/ba8e356d6ed41d7cadb65831d44ff8a15490e262 and I'm pretty much fine to leave it as is.

I'm going to close this, but feel free to raise a new PR if you feel like there's something missing. And please, add a better description of your PR and why you're raising this.