search

abtExp / vecto

🚧 A Javascript mini library to deal with n-dimensional arrays(referenced from numpy). 🚧🚀
https://npmjs.com/vecto
MIT License
1 stars 0 forks source link

Matmul is broken. #20

Open abtExp opened 7 years ago

abtExp commented 7 years ago

While Testing the product of matrix, The elements of the array are not completely being returned as output, instead, some values are being repeated. The arrange logic is erroronous for large number of elements. Requires Testing.

abtExp commented 7 years ago

after some testing, I realised, my arrange method is correct, the problem is with the matmul function, it's doing lesser number of iterations than it was supposed to. So there's an error in my algorithm.

abtExp commented 7 years ago

well that's very bad.

abtExp commented 7 years ago

Fixed The matmul operations

abtExp commented 7 years ago

issue persists, algo fails when the inner axis value is 1. For example [7,1]*[1,4] breaks while every non 1 inner dimension works fine.