search

abtassociates / eva

Eva is a HUD application to aid HMIS Leads with data analysis. It is an open-source project intended for local use by HMIS Administrators in Continuums of Care (CoCs) around the U.S. and its territories.
GNU Affero General Public License v3.0
14 stars 4 forks source link

(Don't) Turn waterfall #547

Closed kiadso closed 2 weeks ago

kiadso commented 4 weeks ago

broke out inflow and outflow types on the Detail tab of the Waterfall, shortened labels a tiny bit for easier reading

alex-silverman commented 4 weeks ago

@kiadso It also looks like the Detail Box is showing "All" for Household Type and Level of Detail. Did we decide to only show those if they're not "All"? If so, no need to change, since, I'm hoping, my most recent Fixing All Served commit will achieve this. If not, let me know, because I may have misunderstood your comment on the Fixing All Served PR.

kiadso commented 4 weeks ago

@kiadso It also looks like the Detail Box is showing "All" for Household Type and Level of Detail. Did we decide to only show those if they're not "All"? If so, no need to change, since, I'm hoping, my most recent Fixing All Served commit will achieve this. If not, let me know, because I may have misunderstood your comment on the Fixing All Served PR.

I created this branch before those fixes were merged, so we'll just have to be sure there's no conflicts once we merge this

alex-silverman commented 3 weeks ago

@kiadso It also looks like the Detail Box is showing "All" for Household Type and Level of Detail. Did we decide to only show those if they're not "All"? If so, no need to change, since, I'm hoping, my most recent Fixing All Served commit will achieve this. If not, let me know, because I may have misunderstood your comment on the Fixing All Served PR.

I created this branch before those fixes were merged, so we'll just have to be sure there's no conflicts once we merge this

Should be fine either way, but you can always merge phase2-dev into a feature branch to bring in those updates.

kiadso commented 3 weeks ago

Hi @alex-silverman thanks for documenting all the issues- I think I addressed them all. Thanks!