abufawwaz / marketlicensing

Automatically exported from code.google.com/p/marketlicensing
Apache License 2.0
0 stars 0 forks source link

LVL should be able to compile with Eclipse warning level set to higher than the default #10

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. Set the Eclipse Java compiler error/warning level to the highest possible 
settings.

2. Integrate the LVL into a project as per the instructions given in the 
documentation.

3. Build the project.

What is the expected output? What do you see instead?

I expect the project to compile without any problems, instead I am getting a 
bunch of compile errors from the LVL code.  Since Eclipse is the officially 
senctioned development platform for Android and LVL, and instructions are given 
how to integrate a project with LVL in Eclipse, there should be no compile 
errors regardless of the users settings.  Currently, the user has to lower the 
warning levels just to satisfy LVL.

What version of the product are you using? On what operating system?

Latest Android SDK tools with Eclipse Helios on Windows platform.
Please provide any additional information below.

Original issue reported on code.google.com by zvasv...@gmail.com on 2 Aug 2010 at 11:54

GoogleCodeExporter commented 9 years ago
Accepting, but for anybody else reading this, please note the comments below 
from the corresponding android-discuss thread:

---------- Forwarded message ----------
From: Xavier Ducrohet <xav@android.com>
Date: Wed, Jul 28, 2010 at 5:38 PM
Subject: Re: [android-developers] My experience with LVL and the precedence it 
sets
To: android-developers@googlegroups.com

On Wed, Jul 28, 2010 at 4:45 PM, Zsolt Vasvari <zvasvari@gmail.com> wrote:
> I just tried integrating LVL into my app.  Some comments on this
> process:
>
> I have my project set up so that compiler Errors/Warnings are almost
> all set to Error level.  When I imported the LVL project, I got all
> kinds of errors.  Mostly missing "this" qualifiers and $NON-NLS tags,
> but some of the errors I saw quite interesting. 

$NON-NLS is something specific to Eclipse that we do not use in Android.
Our convention for the android source code do not enforce the use of
this qualifier.

Original comment by trevorjohns@google.com on 3 Aug 2010 at 7:14