search

abugasavio / hackzor

Automatically exported from code.google.com/p/hackzor
0 stars 0 forks source link

Change forms.py to use newforms #4

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
The Current Form-Manipulator system in Django is being replaced. 
Port to newforms as soon as the next version of Django is released

Original issue reported on code.google.com by ravehan...@gmail.com on 16 Jan 2007 at 7:42

GoogleCodeExporter commented 8 years ago

Original comment by ravehan...@gmail.com on 10 Nov 2007 at 1:42

GoogleCodeExporter commented 8 years ago 
Removing owner for prioritizing

Original comment by ravehan...@gmail.com on 31 Jan 2008 at 12:45

GoogleCodeExporter commented 8 years ago 
I would like to try to resolve this issue.

Original comment by Jakub.Ja...@gmail.com on 20 Feb 2008 at 1:58

GoogleCodeExporter commented 8 years ago 
Assigning to Jakub

Original comment by ravehan...@gmail.com on 20 Feb 2008 at 6:53

GoogleCodeExporter commented 8 years ago

Original comment by Jakub.Ja...@gmail.com on 21 Feb 2008 at 11:14

GoogleCodeExporter commented 8 years ago 
Attaching patch for this issue.

Original comment by Jakub.Ja...@gmail.com on 24 Feb 2008 at 9:35

Attachments:

GoogleCodeExporter commented 8 years ago 
Hey jakub,
Is this the final version of the patch? I remember us going back and forth on a 
few
changes and I'd assumed that you had something pending.

If there's nothing pending, I'll do another review and you can submit it if all 
is ok

Original comment by ravehan...@gmail.com on 23 Mar 2008 at 9:33

GoogleCodeExporter commented 8 years ago 
Sorry, I've been quite busy recently.
Unless we are migrating to Django Trunk, it's final version.

Original comment by Jakub.Ja...@gmail.com on 25 Mar 2008 at 9:08

GoogleCodeExporter commented 8 years ago 
We are migrating to the trunk. More work for you :)

Original comment by ravehan...@gmail.com on 26 Mar 2008 at 7:10

GoogleCodeExporter commented 8 years ago 
Patch with migration to the trunk.

Original comment by Jakub.Ja...@gmail.com on 26 Mar 2008 at 7:20

Attachments:

GoogleCodeExporter commented 8 years ago 
A few comments:

Why have you added slashes to the ends of urls in certain places and removed 
them in
a few other places?
Also I don't think changing this
+        (r'^opc(/|$)', include('hackzor.server.urls')),
is necessary. IIRC django should handle this automatically

Why in form.py,  User.objects.create_user rather than User(). Has the API 
changed?

Delete the __init__ function in Submit solution if you want to remove it. Don't
comment it.

Otherwise all looks ok. Great Job!

Makes changes and attach new diff if necessary.

Original comment by ravehan...@gmail.com on 30 Mar 2008 at 12:31

GoogleCodeExporter commented 8 years ago 
I have altered URLs because I thought that Django trunk handles URLs more strict
(they don't work using builtin development server). My bad.

Using User() rather than User.objects.create_user would require to hash 
password by hand.

__init__ function in SubmitSolution is also my mistake.

Here's patch without URL changes and with SubmitSolution.__init__ deleted.

Original comment by Jakub.Ja...@gmail.com on 31 Mar 2008 at 9:51

Attachments: