search

abuiles / ember-watson

An Ember.js codemod to make upgrades automatic.
https://blog.abuiles.com/ember-watson/
MIT License
305 stars 43 forks source link

Wrap ember-k-codemod #105

Closed cibernox closed 7 years ago

cibernox commented 7 years ago

I've created https://github.com/cibernox/ember-k-codemod for complement a (likely) future deprecation in ember (https://github.com/cibernox/rfcs/blob/deprecate-ember-k/text/0000-deprecate-ember-k.md) but it's probably more idiomatic to distribute it in ember-watson because a lot of people knows and trust the tool.

This naive approach just adds a tasks that in turn runs the binary. There is no tests because ember-k-codemod is tested and its an utility that takes no options.

Let me know if I should change anything on the approach.

knownasilya commented 7 years ago

Thanks, could you also update the readme?

knownasilya commented 7 years ago

@cibernox is this still wip?

abuiles commented 7 years ago

@knownasilya thanks for following -- can you please approve if it looks good to you, and then we can cut a release.

cibernox commented 7 years ago

No, this works well. The only think to take into account is that this command doesn't take a <path> option. It runs automatically in all folders that might contains Ember code (app, addon, lib, tests, test-support...) and it doesn't have a dry-run, since I had no idea how to do that.

abuiles commented 7 years ago

@cibernox can you add a note about

It runs automatically in all folders that might contains Ember code (app, addon, lib, tests, test-support...) and it doesn't have a dry-run, since I had no idea how to do that.

I'll merge after that and release :)

Gracias amigo!

cibernox commented 7 years ago

@abuiles Note added

abuiles commented 7 years ago

🎆