Closed GoogleCodeExporter closed 9 years ago
I've made the changes I believe are required (and added tests to match UserIp)
here:
https://code.google.com/r/danny-google-api-dotnet-client/source/detail?r=5235990
ebf83c88d87cb5d25370309ce4630739f
Original comment by da...@tuppeny.com
on 8 Sep 2012 at 2:44
Thanks, Danny!
@David, can you please review?
Original comment by ccherub...@google.com
on 8 Sep 2012 at 3:30
Thanks Danny I will look into this in the next couple of days.
Original comment by davidwat...@google.com
on 10 Sep 2012 at 10:33
Hi Danny,
Just thinking this through I need you to sign a contributors licence agreement
before I can look at your code. See
http://code.google.com/p/google-api-dotnet-client/wiki/BecomingAContributor the
form can be submitted electronically. Sorry to put a hurdle in front of your
contributions. If you update this issue once you have filled that in, I will
then look at your code.
Sorry once more,
David.
Original comment by davidwat...@google.com
on 12 Sep 2012 at 9:20
lol, no worries, I understand (lawyers, eh? ;-))
All submitted online using the form :-)
Original comment by da...@tuppeny.com
on 12 Sep 2012 at 11:06
Thanks Danny, I have received you agreement (time stamped 2012-09-12 4:05:37)
and will look at this patch this week.
David.
Original comment by davidwat...@google.com
on 12 Sep 2012 at 4:37
Danny,
Thanks so much for your fix to this, and issue 234. These have both been
committed and integrated into the default branch.
You may have received emails from codereview.appspot.com, the code review tool
this project uses, don't worry too much about them, I have driven this change
through there.
If you become a regular contributor pushing your changes through there will
make my job easier. If you just drop in the occasional fix, I'm more then happy
to try and make this as easy for you as I can.
Thanks once more,
David.
Original comment by davidwat...@google.com
on 14 Sep 2012 at 12:16
Great, thanks David :-)
Not sure how much I'll get to even work on my stuff, or if I'll find anything
else worth contributing, but will bear it in mind if I do!
Original comment by da...@tuppeny.com
on 14 Sep 2012 at 5:48
FYI: This has now shipped.
Original comment by davidwat...@google.com
on 21 Sep 2012 at 4:58
Great, thanks :-)
Original comment by da...@tuppeny.com
on 21 Sep 2012 at 5:00
Original issue reported on code.google.com by
da...@tuppeny.com
on 8 Sep 2012 at 2:43