abujehad139 / google-api-dotnet-client

Automatically exported from code.google.com/p/google-api-dotnet-client
Apache License 2.0
0 stars 0 forks source link

BuildRelease imrpovements #297

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
small improvements to the code (by David review on 
https://codereview.appspot.com/7412043/patch/29007/33022)

1. BuildProjects signature is awful
private static Project[] BuildProjects(out FileVersionInfo apiVersion, out 
Project[] allProjects),
using two output arguments and one return value is just not the way to program.

2. When asking the user for response do something similar to (no one time 
questions-response thing):
while(true) {
  RequestUserInput(...);
  if(response == "YES") {...} else
  if(response == "no") { ... break; } else {
    WriteLine("Say yes or no");
  }      
}

3. Change the build release namespace to Google.Tools.....

Original issue reported on code.google.com by pele...@google.com on 5 Mar 2013 at 9:29

GoogleCodeExporter commented 9 years ago

Original comment by pele...@google.com on 5 Mar 2013 at 9:32

GoogleCodeExporter commented 9 years ago

Original comment by pele...@google.com on 17 Sep 2013 at 3:23

GoogleCodeExporter commented 9 years ago
The build release tool was changed completely to support NuGet

Original comment by pele...@google.com on 3 Oct 2013 at 6:26