search

abumq / easyloggingpp

C++ logging library. It is extremely powerful, extendable, light-weight, fast performing, thread and type safe and consists of many built-in features. It provides ability to write logs in your own customized format. It also provide support for logging your classes, third-party libraries, STL and third-party containers etc.
MIT License
3.75k stars 918 forks source link

conan option for default logfile inverse #812

Open CrazyDaisyRecords opened 2 years ago

CrazyDaisyRecords commented 2 years ago

Issue

The conan option "enable_default_logfile" behaves in a inverse way. The conanfile of the package version 9.97.0 handles the option as followed:

if self.options.enable_default_logfile:
            self.cpp_info.defines.append("ELPP_NO_DEFAULT_LOG_FILE")

Proposal

This option shall be handled inverse. 

if not self.options.enable_default_logfile:
            self.cpp_info.defines.append("ELPP_NO_DEFAULT_LOG_FILE")
prince-chrismc commented 1 year ago

Not sure this is project is maintained but in CCI there's a PR for something similar to this https://github.com/conan-io/conan-center-index/pull/14332

It would be amazing is the CCI build script could be brought back here to this project so everyone could benefit from it.