search

abuonomo / paper-data-links

heliophysics query scripts
MIT License
1 stars 1 forks source link

Review script for paper "2023PSJ.....4...70Z" made with predictor "DataLinkerCondenseDetailsWithTemplate" #6

Closed abuonomo closed 2 months ago

abuonomo commented 5 months ago

Created by Paper Data Linking Bot

Please review the download script and instrument details for the paper.

bibcode: 2023PSJ.....4...70Z predictor: DataLinkerCondenseDetailsWithTemplate

abuonomo commented 5 months ago

Firt try at validation script results in this error:

Traceback (most recent call last):
  File "/home/runner/work/paper-data-links/paper-data-links/papers/2023PSJ.....4...70Z/download_script.py", line 27, in <module>
    lasco_c2_query = Fido.search(lasco_time_range, lasco_c2, lasco_orange_wavelength, lasco_clear_wavelength)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.[12](https://github.com/abuonomo/paper-data-links/pull/7/checks#step:8:13).3/x64/lib/python3.12/site-packages/sunpy/net/fido_factory.py", line 313, in search
    query = attr.and_(*query)
            ^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/sunpy/net/attr.py", line 682, in and_
    value &= elem
TypeError: unsupported operand type(s) for &=: 'AttrAnd' and 'Wavelength'
Error: Process completed with exit code 1.

Error is occuring because you cannot query multiple wavelengths in Fido.search by just including more in the Fido.search call.

abuonomo commented 5 months ago

C2 and C3 were being listed as instruments instead of LASCO detectors. HI1 was also being queried as an instrument instead of a detector on SECCHI. Wavelengths needed to put into separate calls. See: 30be2f6781b3f9f2931717a4b2eecc51417b198b