abuonomo / paper-data-links

heliophysics query scripts
MIT License
1 stars 1 forks source link

Review script for paper "2023ApJ...949...14L" made with predictor "DataLinkerWithSupport" #60

Closed abuonomo closed 3 weeks ago

abuonomo commented 2 months ago

Created by Paper Data Linking Bot

Please review the download script and instrument details for the paper.

bibcode: 2023ApJ...949...14L predictor: DataLinkerWithSupport annotated pdf: view here (requires login)

Checklist

Download Script

Instrument Details

Metadata

For more details, refer to the Contributing Guide.

catbyrd commented 3 weeks ago

I'm assuming this is the correct interpretation of what this physical observable is?

From article: Physical Observable: Ionic and elemental composition of the solar wind Supporting Quote: "We then show that each of these intervals correspond to enhancements in the ionic composition signatures of C, O, and Fe."

abuonomo commented 3 weeks ago

@catbyrd I reverted this because when you take a closer look, it appears that this paper does not directly use any instruments which are from the VSO (though it does mention Solar Orbiter mission without using its data). You'll also notice from the "Checks" tab above under "Validate Script" and "Execute the Changed Script" that the query does not lead to any results:

Query for Wind spacecraft data:
Results from 0 Providers:

Query for ACE spacecraft data:
Results from 0 Providers:

When there are no results here, it is usually because the instrument is actually not available using the Fido.search commands which often means the instruments are not actually in the VSO. Since we are trying to limit the scope of what we need to check to something more manageable, for now we can just label these cases as non-vso data and move on without merging.

When in doubt, feel free to tag me. Also, it's super easy to revert changes so it is not really anything to worry about.