aburd / beats-with-friends

A piece of software where beatmakers can make beats with each other.
3 stars 0 forks source link

feat/Login Page v2 #18

Closed OrPerl closed 2 years ago

OrPerl commented 2 years ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR is purely a feature PR.

Before (left), After (right)

What is the current behavior? (You can also link to an open issue here)

The current application doesn't have translations, form validation is implemented manually and the design components are basic HTML with sprinkled CSS.

The header is a very basic text as a logo. Desktop browsers were not taken into account for the design/behavior of the page.

See Issues:

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

This PR changes the behavior of the Login page including validations for the email and password fields. While the Login page is a standalone page, the password validation change can affect existing customers who created weaker password and will have an issue to login.

Following this PR, the signup form should change to reflect the password validation requirement for newly registered users.

Other information:

None.