Closed kimm950 closed 2 years ago
@kimm950 Thanks for this PR! I'm actually working on something somewhat similar. If it's OK, would you mind if I merged #10 with this one?
@aburd sure!!
@kimm950 I messed up this PR bad...somehow when I rebased it got rid of your commits, but I think if you squash merge this, you should get the commit anyway.
As for the PR itself, the way you did it made me rethink how it should be approached! I like your approach of just putting the group stuff on the bottom. So I changed the code to just keep all the "group stuff" in a GroupMenu component!
If you're happy with this, please go ahead and merge!
@kimm950 Also, I wasn't really picky about the styling, so my code may have messed a bit with what you're trying to do (put the group styling in the sequencer). If you wanna change that back go for it!
I really liked what you did with the simple approach of making the active user orange so I definitely wanted to keep that.
I messed up this PR bad...somehow when I rebased it got rid of your commits, but I think if you squash merge this, you should get the commit anyway.
It's all good!
If you're happy with this, please go ahead and merge!
I am happy, let me merge this!
IMPORTANT: Please do not create a Pull Request without creating an issue first. closes https://github.com/aburd/beats-with-friends/issues/8 closes #7
*Any change needs to be documented in issues so that people are aware of what's being developed.
Please check if the PR fulfills these requirements
[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
UI improvement, adding user list feature
What is the current behavior? (You can also link to an open issue here)
there is no visible member list in the
TurnModePage``What is the new behavior (if this is a feature change)?
render the user name list to the TurnModePage.tsx
add active status to the member when it's their turn
use error modal when there is no nextUser
display group name in the header (top-right)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Nope