ENH: adding array broadcast to non scalar outputs

aburrell / apexpy

A Python wrapper for Apex coordinates

MIT License

34 stars 25 forks source link

ENH: adding array broadcast to non scalar outputs #63

Open gregstarr opened 3 years ago

gregstarr commented 3 years ago

This is a rough draft of the feature described in #62 , created this to illustrate the proposed changes

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 653

21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.8%) to 97.647%

Totals
Change from base Build 632:	0.8%
Covered Lines:	389
Relevant Lines:	397

Hi @gregstarr, the codebase is in good enough shape to move forward with this now. Adding unit tests and an example in the docs are probably the next steps. Not any rush, but let me know if you aren't interested in doing this yourself.

gregstarr commented 3 years ago

Okay thanks for letting me know. I'd be happy to do it.

gregstarr commented 3 years ago

Hello, I have not forgotten about this, I am in the midst of finishing my masters thesis and so will have time in about a month.

aburrell commented 1 year ago

Resolved the merge conflicts in the branch: https://github.com/aburrell/apexpy/tree/enh-broadcast-arrays

aburrell / apexpy

ENH: adding array broadcast to non scalar outputs #63

Pull Request Test Coverage Report for Build 653

💛 - Coveralls