aburrell / apexpy

A Python wrapper for Apex coordinates
MIT License
34 stars 25 forks source link

Build wheels for all OS using CI #98

Closed aburrell closed 2 years ago

aburrell commented 2 years ago

Description

Partially addresses #85 by using cibuildwheels to create more wheels for installing apexpy.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Needs CI to test

Test Configuration:

Checklist:

ljlamarche commented 2 years ago

Changes look fine, but how should I test this? Following the new instructions under maintenance?

aburrell commented 2 years ago

Yes, if the new maintenance instructions work for you then you've shown: 1) The instructions work for someone other than myself 2) The wheels exist.

You could also try installing using one of the wheels, if it's not hard.

ljlamarche commented 2 years ago

How do you choose which artifact to select? Just the most recent?

ljlamarche commented 2 years ago

I couldn't get the zip file to download through my browser, but could get it using wget with the url specified by location. It contains the following wheels:

Archive:  wheel_zip
  inflating: apexpy-1.1.0-cp310-cp310-linux_x86_64.whl  
  inflating: apexpy-1.1.0-cp310-cp310-macosx_10_16_x86_64.whl  
  inflating: apexpy-1.1.0-cp310-cp310-win_amd64.whl  
  inflating: apexpy-1.1.0-cp37-cp37m-linux_x86_64.whl  
  inflating: apexpy-1.1.0-cp37-cp37m-macosx_10_16_x86_64.whl  
  inflating: apexpy-1.1.0-cp37-cp37m-win_amd64.whl  
  inflating: apexpy-1.1.0-cp38-cp38-linux_x86_64.whl  
  inflating: apexpy-1.1.0-cp38-cp38-macosx_10_16_x86_64.whl  
  inflating: apexpy-1.1.0-cp38-cp38-win_amd64.whl  
  inflating: apexpy-1.1.0-cp39-cp39-linux_x86_64.whl  
  inflating: apexpy-1.1.0-cp39-cp39-macosx_10_16_x86_64.whl  
  inflating: apexpy-1.1.0-cp39-cp39-win_amd64.whl  
  inflating: numpy-1.21.6-cp37-cp37m-win_amd64.whl  
  inflating: numpy-1.23.5-cp310-cp310-win_amd64.whl  
  inflating: numpy-1.23.5-cp38-cp38-win_amd64.whl  
  inflating: numpy-1.23.5-cp39-cp39-win_amd64.whl  

I did manage to install the appropriate wheel for my computer and everything appears to work!

aburrell commented 2 years ago

I updated the download instructions based on your experience. If you're happy, go ahead and approve the pull request :)