aburrell / ocbpy

Convert between magnetic and adaptive, polar boundary coordinates
BSD 3-Clause "New" or "Revised" License
7 stars 7 forks source link

MAINT: Bugs and updates #131

Closed aburrell closed 5 months ago

aburrell commented 5 months ago

Description

Addresses several issues - #128, #126, and #109 - and also:

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Ran unit tests locally.

Test Configuration

Checklist:

jklenzing commented 5 months ago

For the coveralls bug, the individual jobs show up as "successful", but in the coveralls section I found this:

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.7.17/x64/bin/coveralls", line 5, in <module>
    from coveralls.cli import main
  File "/opt/hostedtoolcache/Python/3.7.[17](https://github.com/aburrell/ocbpy/actions/runs/8481925380/job/23240181317#step:10:18)/x64/lib/python3.7/site-packages/coveralls/__init__.py", line 2, in <module>
    from .api import Coveralls
  File "/opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/coveralls/api.py", line 13, in <module>
    from .reporter import CoverallReporter
  File "/opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/coveralls/reporter.py", line 10, in <module>
    from coverage.report import Reporter
ImportError: cannot import name 'Reporter' from 'coverage.report' (/opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/coverage/report.py)

It looks like the jobs are not being uploaded for some reason.

coveralls commented 5 months ago

Coverage Status

coverage: 99.574% (+0.5%) from 99.089% when pulling 294ddd6d1bbdba0dc76b561cc31543bf3875616e on bug_and_updates into 1046849b460fbabf1dabfbedf7f543d90c2cae85 on develop.

aburrell commented 5 months ago

The GitHub Actions coveralls app was not useful because:

aburrell commented 5 months ago

coveralls coverage report still differs from local coverage report by 11% due to: