aburrell / ocbpy

Convert between magnetic and adaptive, polar boundary coordinates

BSD 3-Clause "New" or "Revised" License

7 stars 7 forks source link

DEP: removed support for `dmsp_ssj_boundaries` #139

Closed aburrell closed 4 months ago

aburrell commented 4 months ago

Description

Removed support for old package `dmsp_ssj_boundaries. Fixes #129 and #135.

Type of change

Please delete options that are not relevant.

Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Unit tests.

import ocbpy

# Fetch the zenodo archive for all dates and satellites.
ocbpy.boundaries.dmsp_ssj_files.fetch_ssj_boundary_files()

Test Configuration

Operating system: OS X Big Sur
Version number: Python 3.9
Any details about your local setup that are relevant: develop branch of pysat

Checklist:

[x] Make sure you are merging into the develop (not main) branch
[x] My commits are formatted appropriately (following the SciPy/NumPy style)
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] Add a note to Changelog.rst, summarising the changes
[x] Add yourself to AUTHORS.rst and .zenodo.json

coveralls commented 4 months ago

coverage: 99.775% (+7.6%) from 92.213% when pulling 5c17a346d555858dfa65fda72fbef58466e71e1e on ssj_dep into 6fe61d2de459843d8057a0a95e2cb83b821951cd on develop.