BUG: sign of the eccentricity

aburrell / ocbpy

Convert between magnetic and adaptive, polar boundary coordinates

BSD 3-Clause "New" or "Revised" License

7 stars 7 forks source link

BUG: sign of the eccentricity #62

Closed aburrell closed 4 years ago

aburrell commented 4 years ago

Addresses a bug where the eccentricity sign is negative in the AMPERE elliptical correction function in ocb_correction.py. Physically, the eccentricity cannot be negative. This bug was introduced by a typo in the original version of the elliptical equation (a negative sign in the denominator).

This addresses issue #58.

coveralls commented 4 years ago

Coverage remained the same at 76.345% when pulling 057196db8009a1233e61a3371ac99e31cdacc4fe on ecc_bug_fix into eb7e44151d7db453c0104da85a170879e259c01b on develop.