Final Project Feedback - Githubissues

abusomani / blockchain-developer-bootcamp-final-project

Consensys Blockchain Bootcamp Final Project

blockchain-developer-bootcamp-final-project-phi.vercel.app

10 stars 6 forks source link

Final Project Feedback #1

Open ConsenSys-Academy opened 2 years ago

ConsenSys-Academy commented 2 years ago

Hey @abusomani !! Great job on your Final Project! We'll be approving it on the course itself in a week or two, but here's your feedback in the meanwhile:

Frontend

Really love the layout, Razzle seems like it's a great way to bootstrap the project
Love these images, the flow is really nice, waiting two block confirmations is a smart guard rail
Etherscan link nice touch -- very solid user experience

Testing

Really interesting testing structure with the tx = {} function input, I had not seen that before! (PS Do you really think Solana is the future??)
Nice setup here at the beginning with account deconstruction
Really solid first tests testing the main usage of the contract

Design and Security

Commenting in your contract is excellent, great job there
I mean this in the best way possible, your code is very terse and tight: concise! I think that's a really great security feature
This is a great implementation of a workflow, @abusomani. Very straightforward and to the point, no frills, really great job implementing your vision

Awesome job, @abusomani . Congratulations!

abusomani commented 2 years ago

Thanks @ConsenSys-Academy for the feedback ❤️