abutaha / aws-es-proxy

aws-es-proxy is a small web server application sitting between your HTTP client (browser, curl, etc...) and Amazon Elasticsearch service.
Apache License 2.0
595 stars 203 forks source link

`go.sum` is missing #131

Closed ZhongRuoyu closed 1 year ago

ZhongRuoyu commented 1 year ago

Hi. While packaging aws-es-proxy 1.5 for Homebrew (https://github.com/Homebrew/homebrew-core/pull/125017) we noticed the following build error (full logs here, error starts here):

  ==> go build -trimpath -o=/opt/homebrew/Cellar/aws-es-proxy/1.5/bin/aws-es-proxy
  aws-es-proxy.go:23:2: missing go.sum entry for module providing package github.com/aws/aws-sdk-go/aws (imported by github.com/abutaha/aws-es-proxy); to add:
    go get github.com/abutaha/aws-es-proxy
  aws-es-proxy.go:24:2: missing go.sum entry for module providing package github.com/aws/aws-sdk-go/aws/credentials (imported by github.com/abutaha/aws-es-proxy); to add:
    go get github.com/abutaha/aws-es-proxy
  aws-es-proxy.go:25:2: missing go.sum entry for module providing package github.com/aws/aws-sdk-go/aws/credentials/stscreds (imported by github.com/abutaha/aws-es-proxy); to add:
    go get github.com/abutaha/aws-es-proxy
  aws-es-proxy.go:26:2: missing go.sum entry for module providing package github.com/aws/aws-sdk-go/aws/endpoints (imported by github.com/abutaha/aws-es-proxy); to add:
    go get github.com/abutaha/aws-es-proxy
  aws-es-proxy.go:27:2: missing go.sum entry for module providing package github.com/aws/aws-sdk-go/aws/session (imported by github.com/abutaha/aws-es-proxy); to add:
    go get github.com/abutaha/aws-es-proxy
  aws-es-proxy.go:28:2: missing go.sum entry for module providing package github.com/aws/aws-sdk-go/aws/signer/v4 (imported by github.com/abutaha/aws-es-proxy); to add:
    go get github.com/abutaha/aws-es-proxy
  aws-es-proxy.go:29:2: missing go.sum entry for module providing package github.com/sirupsen/logrus (imported by github.com/abutaha/aws-es-proxy); to add:
    go get github.com/abutaha/aws-es-proxy
  aws-es-proxy.go:30:2: missing go.sum entry for module providing package go.mongodb.org/mongo-driver/bson/primitive (imported by github.com/abutaha/aws-es-proxy); to add:
    go get github.com/abutaha/aws-es-proxy
  aws-es-proxy.go:31:2: missing go.sum entry for module providing package golang.org/x/net/publicsuffix (imported by github.com/abutaha/aws-es-proxy); to add:
    go get github.com/abutaha/aws-es-proxy

It seems that the go.sum file was removed from the repo in commit https://github.com/abutaha/aws-es-proxy/commit/88c982701c48ad7d22721020812d9adb57e614a9. However, having go.sum committed to the repository is listed as one of the best practices for releasing modules in the Go wiki, and this section explains why. Would you consider adding them back? Thanks.

abutaha commented 1 year ago

Hi, file re-added. I manually deleted it due to a conflict and forgot to re-include it. Now this is fixed. Thanks for the note.

ZhongRuoyu commented 1 year ago

Thanks @abutaha!