search

abuzaforfagun / Invoice.Microservices.ThirdPartyAPIIntegration

Scaleable fault tolerance microservices to communicate third party API
9 stars 3 forks source link

Remove empty constructors from Domain Model #3

Closed abuzaforfagun closed 2 years ago

abuzaforfagun commented 2 years ago

There is a couple of empty constructors in the domain models, what is used to make Automapper happy.

We can remove that empty constructor following the guideline of auto mapper.

We also can think about removing Automapper. As we are not doing any complex mapping there.

ysnarafat commented 2 years ago

Can work on this?

abuzaforfagun commented 2 years ago

Sure, you are most welcome.

I was thinking about removing the AutoMapper and create the object using the parameterized constructor. I appreciate if you can do that and create a PR.

ysnarafat commented 2 years ago

Ok, I will do accordingly.