libvpx does not support timebase > 1

abwiz0086 / webm

Automatically exported from code.google.com/p/webm

1 stars 0 forks source link

libvpx does not support timebase > 1 #489

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

libvpx requires timebase numerator to be smaller than denominator, so its 
magnitude must be < 1. It returns an error on encoder init otherwise.

There should be no reason for this limitation, setting the timebase such that 
its magnitude is > 1 is perfectly sane for streams with less than 1 fps.

Original issue reported on code.google.com by anton.kh...@gmail.com on 5 Oct 2012 at 6:05

GoogleCodeExporter commented 9 years ago

Original comment by albe...@google.com on 11 Oct 2012 at 10:10

Changed state: Available
Added labels: Mstone-14, Pri-3
Removed labels: Pri-2

GoogleCodeExporter commented 9 years ago

I was able to change one line (libvpx-1.2.0) in vp8/vp8_cx_iface.c

<    RANGE_CHECK(cfg, g_timebase.num,        1, cfg->g_timebase.den);
-
>    RANGE_CHECK(cfg, g_timebase.num,        1, 1000000000);

Works great for me.  The webm overview claims no limitations on frame rate- but 
there could be another reason this is this way.   

I'll look into submitting this as a patch after Christmas.

-Johnny Klonaris

Original comment by yout...@jawknee.com on 21 Dec 2013 at 11:54