abyot / sun-pmt

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Adjustments to reporting tables #39

Closed kreinhardt closed 7 years ago

kreinhardt commented 7 years ago
kreinhardt commented 7 years ago

Another thing: not all the actions with no reported data are turning grey: image

If having the action where there is no data reported turn grey is difficult - it's ok to just leave the text black. However, I would want this to be consistent throughout the reports.

abyot commented 7 years ago

Hi @kreinhardt,

These are all fixed except the excel warning thing. I do not have a solution for that... the thing is a typical problem of proprietary products. Microsoft Excel checks for strict formatting, literally rejecting anything that is generated with client side technology.

One solution that definitely works is that to tell each machine - that downloads and opens excel reports - not to check for strict formatting. However, this is not a good solution for many reasons.

kreinhardt commented 7 years ago

Thanks @abyot ! The tables are looking good.

It seems like the actions not taking place are not being grey-ed out in the geographic coverage reports. Can you check this?

Can you also remove the option to download as a PDF? The tables look a bit weird b/c there are too wide for a normal page in this format. The excel feature is much more useful for us anyway!

abyot commented 7 years ago

Hi @kreinhardt

Can you tell me the report parameters you have for geographic coverage?

kreinhardt commented 7 years ago

Sorry - I should have included that.

Org unit: Rwanda Reporting level: Province Stakeholder role: Field Implementer (since all acitons have to have this filled....) Actions: All

In the East Province, the action Provide multiple micronutrient supplements (MNPs/Ongera) should be grey, as well as the Schools target group for Promotion of hygiene/handwashing.

kreinhardt commented 7 years ago

It seems to be happening for some: image

image

abyot commented 7 years ago

Hi @kreinhardt,

Have made a fix just now. See if it working this time...

kreinhardt commented 7 years ago

Thanks @abyot - looks good now!

One last change (I hope): can you change the text for the geographic coverage table to:

The table below presents the number and percentage of geographic areas that each stakeholder is supporting. The table can be created separately for each stakeholder role (field implementer, catalyst, funder and responsible ministry). The number and percentage in the table always refer to the sub-national level at which the data was collected. Use the 'Report filters' to define the geographic area, year, stakeholder role and actions to display.

image

abyot commented 7 years ago

Fixed.

kreinhardt commented 7 years ago

Thanks @abyot . One more.... (sorry, this really should be the last adjustment....)

Can you change the text for the population coverage table to:

The table below presents the percentage of beneficiaries covered by each stakeholder. The table can be created separately for each stakeholder role (field implementer, catalyst, funder and responsible ministry). Use the 'Report filters' to define the geographic area, year, stakeholder role and actions to display.

abyot commented 7 years ago

:(

Ok, I will add this one... but for the next ones, we will have to do it in batch ... like deploying fixes in every other day.

It is a little inconvenient if I have to switch between my codebase and database every now and then

kreinhardt commented 7 years ago

I'm sorry!!!! This is the last one for now but in the future I will provide others as a batch. Thanks for doing all of these though!

I'm going to look through everything again but I think that we are almost ready to clear and build the demo version if you have the description of the metadata structure ready for me?

abyot commented 7 years ago

Fixed. It is ok, it is just that I have to clear all the stuff from dashboard, replace with the mapping one. once done clear all the mapping stuff, replace with dashboard... and then repeat :(

abyot commented 7 years ago

I will try to have the metadata structure description document by Thursday. will that be late?

kreinhardt commented 7 years ago

Thanks @abyot - Thursday for the metadata works for me.

I will continue to double/triple/... check things between now and then in case there is any other changes. However, I don't think there will much... if any.

abyot commented 7 years ago

ok, great.