search

abzubarev / web-developer-form-filler-ext

This extension is used by developers to make it easy to fill forms
MIT License
113 stars 53 forks source link

Fix change event doesn't work and confirm delete issue #5

Closed oliverzy closed 10 years ago

oliverzy commented 10 years ago

Hi,

This chrome extension is very useful for development uses. I just fix the two issues I found when I use it in latest Chrome 35.

1) JQuery change function somehow doesn't work, the form control cannot receive change event if you attached change handler. In this fix, I use browser native event api, it works well.

2) Delete button cannot work. The confirm dialog disappeared soon after it showed. I have no chance to click okay. In this fix, I use bootstrap-confirmation module to implement this feature.

abzubarev commented 10 years ago

Thanks for your fixes! I cherry-picked your fix for change event and it will be pushed to master with your ownerwhip. About the confirmation bug, even though I can't reproduce it, I decided to remove the confirmation completely.