ac-custom-shaders-patch / acc-extension-config

Configuration files for Assetto Corsa Custom Shaders Patch
225 stars 220 forks source link

Paint colour changes selflight/extra light intensity #189

Open HumanRightsAbuser opened 2 years ago

HumanRightsAbuser commented 2 years ago

Screenshot_allies_porsche_93075_endlessfloor_28-0-122-14-29-0 white paint Screenshot_allies_porsche_93075_endlessfloor_28-0-122-14-29-56 dark paint Screenshot_allies_porsche_93075_endlessfloor_28-0-122-14-29-16 bright interior color Screenshot_allies_porsche_93075_endlessfloor_28-0-122-14-29-51 dark interior color

All versions.

Marocco2 commented 2 years ago

Dunno if it is intended or not

Trava715 commented 2 years ago

image image

Confirmed on CSP 1.74

Trava715 commented 2 years ago

If my memory serves that happens because all shaders in AC use diffuse texture as multiplier for ambient/diffuse/emissive properties which is... not correct unless the object in question is perfectly matte. Instead material properties should be taken into account first with diffuse color acting as multiplier on top of them.

Black paint should reflect less light than white paint but right now it's greatly exaggerated due to base reflectivity of the material itself not being taken into account.

Trava715 commented 2 years ago

20220209_182851 20220209_183004

Here's an example. Same issue affects all shaders in AC including PBR ones. Anything with a dark diffuse texture just doesn't reflect any light.

Trava715 commented 2 years ago

image image image

Marocco2 commented 2 years ago

Still present in 0.1.77 public?