search

ac-i2i-engineering / TimeSpace-AI

Apache License 2.0
0 stars 1 forks source link

Weird setup for GoogleCalendarService and ModelInitializer #11

Open AidenTag opened 4 days ago

AidenTag commented 4 days ago

Right now we are instantiating instances of these classes, which will then CONTAIN either a service or model. So you have to do something along the lines of 

calendar_service = GoogleCalendarService()
self.service = calendar_service.service

or 

self.model_init = ModelInitializer(..........)
...
self.model_init.model......

This seems like an inappropriate implementation of these classes. Wouldn't it make more sense for these classes to contain a 'static'-type method which simply returns a model/service? Like 

self.model = ModelInitializer.init(...........)
...
self.model........