ac2cz / Falcon

Amsat Pacsat Groundstation for FalconSat3
9 stars 0 forks source link

Fail to close directory holes #104

Open ac2cz opened 6 months ago

ac2cz commented 6 months ago

This happened when we deleted some files while requesting the dir.

We keep sending this in a loop

May 27 15:09:57 pi-arex-gw launch_iors_control.sh[2643]: DIR REQ: flags: 10 BLK_SIZE: 00f4  - 2 holes: 2024-05-26 15:51:51,2038-01-19 03:14:07 2024-05-18 13:05:42,2024-05-18 13:05:42
May 27 15:09:57 pi-arex-gw launch_iors_control.sh[2643]: DIR FILL REQUEST: flags: 10 BLK_SIZE: 00f4
May 27 15:09:57 pi-arex-gw launch_iors_control.sh[2643]: PFH: File:004e         .    Source:AC2CZ Dest:DFDSAF Crc:2000 Size:0413 Cr:2024-05-24 23:34:39 Up:2024-05-24 23:35:04  Contains:AC2CZ48.txt
May 27 15:09:57 pi-arex-gw launch_iors_control.sh[2643]: PFH: File:004e         .    Source:AC2CZ Dest:DFDSAF Crc:2000 Size:0413 Cr:2024-05-24 23:34:39 Up:2024-05-24 23:35:04  Contains:AC2CZ48.txt
May 27 15:09:57 pi-arex-gw launch_iors_control.sh[2643]: PFH: File:0046         .    Source:AC2CZ Dest:DFDSAF Crc:232d Size:0411 Cr:2024-05-18 13:22:22 Up:2024-05-18 13:23:27  Contains:AC2CZ48.txt
May 27 15:09:57 pi-arex-gw launch_iors_control.sh[2643]: PFH: File:0046         .    Source:AC2CZ Dest:DFDSAF Crc:232d Size:0411 Cr:2024-05-18 13:22:22 Up:2024-05-18 13:23:27  Contains:AC2CZ48.txt

image

ac2cz commented 6 months ago

We can see file 70 header was sent to close the hole. It now has old and new dates that close it. But we ignore it as there is still a hole between file 62 and file 65 but neither of those file exist on the server any more.

So we need to note that a more recent header (in terms of upload time) has old and new dates that close the hole. So we should not be requesting it.

We also keep requesting the hole from file 80. i.e from 15:51 but file 80 does not exist. File 78 is the newest file now. This means that its uptime should have been updated when file 80 was removed. Otherwise we will not know that file 78 should be closing the hole for the most recent file.

ac2cz commented 6 months ago

In fact the ground station should be paying attention to the N bit. When the header for file 78 is received it indicates that it is the most recent file on the server. Subsequent requests should use this file to try to fill files into the future.