search

ac2cz / FoxTelem

AMSAT Fox-1 Telemetry Decoder
GNU General Public License v3.0
52 stars 17 forks source link

We are missing frames when sent to the server from version 1.03f #148

Closed ac2cz closed 8 years ago

ac2cz commented 8 years ago

We seem to get duplicate STP files from FoxTelem, with the second file replacing a file that should have been sent.

e.g. From VH5HI running 1.03f Reset 613 uptime 1023109 is missing Instead we get Reset 613 uptime 1023104 twice in the following two STP files: 20160227071647.972.stp.processed 20160227071648.973.stp.processed

It has this data: Sequence: 3324 Source: amsat.fox-1a.ihu.duv Length: 768 Date: Sat, 27 Feb 2016 07:16:42 UTC Receiver: VK5HI Rx-Location: S 34.7607 E 138.6636 30 Receiver-RF: SDR-Radio Funcube Pro+ Demodulator: FoxTelem 1.03f - 27 January 2016 (windows 7)

AMSAT FOX-1 Telemetry Captured at: 2016/03/01 02:20:37 ID: 0001 RESET COUNT: 0613 UPTIME: 1023104 TYPE: 0004

RADIATION EXPERIMENT DATA: 0x36 0x90 0xfa 0x77 0x34 0x44 0x34 0x03 0x00 0x00 0x3d 0x00 0xfa 0xe3 0x02 0xe0 0x19 0xc0 0x01 0xb0 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00

ac2cz commented 8 years ago

Duplicates were being sent because the Frame queue was sorted in the wrong order. We were adding and removing Frames at the head. It was possible for a Frame to be read and sent. Then when it was removed we actually removed the next Frame that was added. We then read the same Frame again and resent it.