search

ac2cz / FoxTelem

AMSAT Fox-1 Telemetry Decoder
GNU General Public License v3.0
52 stars 17 forks source link

Command Count is not displayed #261

Closed burnsfisher closed 7 years ago

burnsfisher commented 7 years ago

This may be bogus because I was quite sure I had seen it earlier on AO-85, but I can't find it now on any of the tabs.

ac2cz commented 7 years ago

On AO-85 "Number of Commands Received Since Boot" is in the Diagnostic Info as part of the rotation. That is also true on Fox-1E.

Chris

On Thu, Jun 29, 2017 at 5:57 PM, Burns Fisher notifications@github.com wrote:

This may be bogus because I was quite sure I had seen it earlier on AO-85, but I can't find it now on any of the tabs.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ac2cz/FoxTelem/issues/261, or mute the thread https://github.com/notifications/unsubscribe-auth/AOI1WUA1NJVLolq104T9iTy2G3vwEuF8ks5sJB2rgaJpZM4OJ6tO .

-- Chris E. Thompson chrisethompson@gmail.com g0kla@arrl.net

burnsfisher commented 7 years ago

Odd. Do you have special code to do that? NumCmds is in the common section, so I assume it comes down in both Realtime and Min/Max. The ring buffer is in diagnostics, though.

It's possible I moved it for E because I realized trying to command A that seeing that number change is an important way to tell if you got in, and in diags it does not happen that often.

burnsfisher commented 7 years ago

Ok, a bunch of issues, largely related to a change in IHU. First, the command count is no longer in diagnostics, which is why I never saw it. But worse, I had removed it from the enum so many of the diags had to wrong code and it was really screwed up. I've fixed that.

Let's talk about how bad the issue of the number of commands changing location is. In the meantime, I'll put it in diags too so we have something at least.

burnsfisher commented 7 years ago

Here is a change in the diagnostic for the command count. It used to be a 24 bit integer. Now it is 8 bits of hardware command, 8 bits of software command, 8 bits unused.

ac2cz commented 7 years ago

Testing with X5.4h and FoxTelem 1.05k, the Diagnostic info shows "Number of Commands Since Boot: 1". Which is incorrect as no commands have been issued. I have not yet made a change to parse this out into software / hardware, but I would have still expected it to be 0. Number Of Commands also reports as 1.

Please clarify how the 8 bits are laid out. I assume 8 LSBs are hardware, next 8 are software, 8 MSB are ignored?

burnsfisher commented 7 years ago

I believe the 1 showing up in diags is a bug which I fixed. Maybe it is in i. But yes, the order is as you said.

On Tue, Jul 4, 2017 at 7:52 PM, Chris Thompson notifications@github.com wrote:

Testing with X5.4h and FoxTelem 1.05k, the Diagnostic info shows "Number of Commands Since Boot: 1". Which is incorrect as no commands have been issued. I have not yet made a change to parse this out into software / hardware, but I would have still expected it to be 0.

Please clarify how the 8 bits are laid out. I assume 8 LSBs are hardware, next 8 are software, 8 MSB are ignored?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ac2cz/FoxTelem/issues/261#issuecomment-312967832, or mute the thread https://github.com/notifications/unsubscribe-auth/ACTTPD_EOY7J2kKR3CVAOFqUv9iceVgOks5sKtApgaJpZM4OJ6tO .

burnsfisher commented 7 years ago

Looks like the number of commands is correctly starting out at 0 in X5.4i flight software. But I'll move it as we discussed by mail.

burnsfisher commented 7 years ago

Downlink version 2.5, which is implemented in Flight Software X5.4i, has the hardware and software command count as separate bytes in realtime specific data rather than in common. They are still in the diagnostics so that I can see them before this gets into FoxTelem, but they will disappear from there.

ac2cz commented 7 years ago

Fixed in 1.05l