search

ac2cz / FoxTelem

AMSAT Fox-1 Telemetry Decoder
GNU General Public License v3.0
52 stars 17 forks source link

FOX1A_rttelemetryFM.csv has a Pad that causes server crash #505

Closed ac2cz closed 5 years ago

ac2cz commented 6 years ago

Somehow the FOX1A rttelemetry layout now has a Pad at the end of it. We don;t have that on amsat.org. On amsatfox.org it causes the server to crash.

When and how did this get introduced?

It is not in 1.06. It was not in earlier 1.07 builds.

ac2cz commented 6 years ago

This was from this commit: https://github.com/ac2cz/FoxTelem/commit/2604ec740621f9bd78042a30669dcdea0f6b4ac4

It was very deliberate and put in a pad for every layout. I need to make sure that the server is ignoring the pads. That does not seem to be the case for the server that we have on amsatfox.org. These layouts have not made it to amsat.org. WITH THE EXCEPTION OF FOX-1CLIFF.

The pad exists in the Fox-1Cliff layout. So this might be a problem,

ac2cz commented 6 years ago

One approach might be to adjust the tables so they match, by adding the PADs. But the tables are large and in constant use. Is that a sensible idea. The fields will never be updated. So best to ignore them on the server and never CREATE them or add data to them with INSERT or UPDATE.

ac2cz commented 6 years ago

If I do not migrate a new server then the pre-1.07 Fox-1Cliff layout should be sent to amsat.org and the tables re-created.

ac2cz commented 6 years ago

DONE for Fox-1Cliff. The Fox3 tables have been recreated from the 1.06r layouts. This will be removed from release 1.07 and made part of the next server release. The new code must cope with these layouts.

ac2cz commented 5 years ago

This is implemented on amsat.org. All tables are now adjusted to match the latest layouts and contain the pads. The latest server is running and stable (v0.32b).