search

ac2cz / FoxTelem

AMSAT Fox-1 Telemetry Decoder
GNU General Public License v3.0
52 stars 17 forks source link

Allow use of RTL2832 #734

Closed ppicazo closed 2 years ago

ppicazo commented 2 years ago

I have a few Nooelec SMArt SDR devices (which outperform most of the other RTL-SDRs I've compared it to) and they use the RTL2832U / E4000, they are not currently detected by FoxTelem, but seem to work great on Windows if I change the device id to 0x2832.

This PR tries that device id after it doesn't find a device with the existing device id of 0x2838. It would probably be better to refactor findDevice to take in an array of vendor/device ids, but getting this simple fix in will allow me to test within Fox-In-A-Box.

ac2cz commented 2 years ago

Thanks for the pull request @ppicazo. I agree that I need a better algorithm to open these devices. Historically I created a list of all USB devices and presented them to the user. So I did not need to store these hard coded device ids. But I can't seem to reliably close the USB devices after the initial scan, so I switched to the current method. I think I had either an issue with the Java LibUSB library or just an error on my part.

Anyway, I merged this into master and will merge that into my branch 1.12, which is the latest development release. I'll put it into 1.12u or later once I build it.

ppicazo commented 2 years ago

@ac2cz Thanks for merging this, any ballpark ETA on when 1.12u will drop?

ac2cz commented 2 years ago

Hi Paul,

If you need a test build then let me know. I am waiting for feedback from the engineering team before building a new version.

regards, Chris

On Thu, Mar 10, 2022 at 4:00 PM Paul Picazo @.***> wrote:

@ac2cz https://github.com/ac2cz Thanks for merging this, any ballpark ETA on when 1.12u will drop?

— Reply to this email directly, view it on GitHub https://github.com/ac2cz/FoxTelem/pull/734#issuecomment-1064499398, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRDKWJVAXRRXANI3HX76PDU7JPGZANCNFSM5P3KDISQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- Chris E. Thompson @. @.