search

ac2cz / pi_pacsat

Open source implementation of the Pacsat protocol based on public documents. Designed to run on a Linux computer using Direwolf as the TNC
4 stars 1 forks source link

iors_control and pi_pacsat can end up using different log file folders #35

Closed ac2cz closed 4 months ago

ac2cz commented 5 months ago

This is a bug in pi_pacsat because it uses get_folder_str() to find the log file folder. It needs to use make_dir_path(get_folder_str(FolderLog), log_path);

Moved from https://github.com/ac2cz/iors_control/issues/99

ac2cz commented 4 months ago

Actually, pi_pacsat is passed a data_dir by iors_control and the log file dir is guaranteed to be in that. Given this is also going to be the folder that pi_pacsat uses to add log files to the dir, that seems correct. So if there is a bug then it is a configuration issue to make sure that iors_control is passing the same data_dir to pi_pacsat that it is using itself.

ac2cz commented 4 months ago

iors_control uses make_dir_path for the log file and when it passes the data_dir to pi_pacsat. So this can be closed.