quoted correspondence below your signature truncates the fields .history() returns

ac3cloud / roust

Ruby client for Request Tracker's REST API

Other

6 stars 4 forks source link

quoted correspondence below your signature truncates the fields .history() returns #2

Open nerdyness opened 10 years ago

nerdyness commented 10 years ago

running

# working
rt.history('1234567', { :format => 'long' })
=> [ .., {"id"=>"xxxxxxxx", "ticket"=>"1234567", "timetaken"=>"5", "type"=>"Correspond", "field"=>"", "oldvalue"=>"", "newvalue"=>"", "data"=>"No Subject", "description"=>"Correspondence added by xxxxx", "content"=>"content...", "creator"=>"xxxx", "created"=>"2014-03-20 04:35:58", "attachments"=>[]} , ..]
# not working
rt.history('1234568', { :format => 'long' })
=> [ .., {"id"=>"xxxxxxxx", "ticket"=>"1234568", "timetaken"=>"10", "type"=>"Correspond", "field"=>"", "oldvalue"=>"", "newvalue"=>"", "data"=>"No Subject", "description"=>"Correspondence added by xxx", "content"=>"content..."} , ..]
# notice the last few fields are missing in the hash?

They disappear somewhere here:

th = Mail.new(item)

It's bad style anyway @TimCorcoran ;)

nerdyness commented 10 years ago

I've created a fix for this in the branch "fix_missing_headers", @auxesis. I'd be super-keen to have a chat to you about this and discuss the best way forward.

auxesis commented 10 years ago

@nerdyness ping me whenever you've got a moment.

nerdyness commented 10 years ago

I noticed the "gemspec" in roust's Gemfile... We obviously forked roust from somewhere but I couldn't find where. Should I create an issue with them instead of here?

I feel like ideally I contact the maintainer/developer of roust and tell them what's going on, ask them what they feel like the best way of fixing this will be and then work with them to have it fixed upstream.

auxesis commented 10 years ago

@nerdyness I am the owner, creator, maintainer of Roust.

It's entirely a Bulletproof creation. It was originally a fork of rt-client, however the code is significantly different enough that you should consider Roust a separate project.

nerdyness commented 10 years ago

The following quote from README.md confused me: "It is a fork of rt-client by Tom Lahti."

Okay, that changes the game a bit. Let me ask you the following

Why do you have ruby-2.0.0 in the .ruby-version file?
As per the "fix_missing_headers" branch I've created, TMail returns all headers as expected while TMail's replacement Mail simply truncates them. Should I raise an issue with the maintainer of Mail about this or even try to submit a PR?
Should all references to TMail be updated to use the Mail gem?

auxesis commented 10 years ago

.ruby-version is set to 2.0.0-p247 because it's the minimum version of Ruby support by the library. Please do not change this.
There should be no references to TMail anywhere. Please don't use TMail. The library is deprecated and no longer maintained. It does not work on Ruby > 1.8.
Please take a look at getting Roust to do what you want it to do with Mail. I guarantee it's a regex bug somewhere in these lines in history().

auxesis commented 10 years ago

@nerdyness one other thing to consider - this project is completely open source and public to the world (this means people outside of Bulletproof are able to see issues, source code).

Please ensure you strip out any compromising details from content.